Fix {image/video/audio}_token_ids in ProcessorMixin#46500
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Contributor
|
CI Dashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
approved these changes
Jun 8, 2026
zucchini-nlp
left a comment
zucchini-nlp
left a comment
Member
There was a problem hiding this comment.
Thanks, just to be safe let's check that these private properties aren't getting serialized in a dict when we save
6 tasks
Member
Author
>>> from transformers import ProcessorMixin
>>> processor = ProcessorMixin()
>>> processor.image_token_ids = [0, 1, 2]
>>> processor.image_token_ids
[0, 1, 2]
>>> processor.to_dict()
{'processor_class': 'ProcessorMixin'} |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
hmellor
added
the
for patch
khushali9
pushed a commit
to khushali9/transformers
that referenced
this pull request
Jun 8, 2026
…46500) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
louzongzhi
pushed a commit
to louzongzhi/transformers
that referenced
this pull request
Jun 10, 2026
…46500) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
louzongzhi
pushed a commit
to louzongzhi/transformers
that referenced
this pull request
Jun 10, 2026
…46500) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
ArthurZucker
pushed a commit
that referenced
this pull request
Jun 11, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#45493 converted these attributes to properties. This breaks custom models which set
{image/video/audio}_token_idsdirectly because:image_token_idThis PR maintains BC by:
{image/video/audio}_token_idshas been explicitly set